Planet Caravan Style Bug?

[siliconsara]

I know it might be waaay too early to start knocking on Planet Caravan since the code roll out hasn't been publicly announced yet, but I thought I'd nip this problem quickly so other users can enjoy this beautiful theme without that *one* problem that irks them.

There's a styling bug when it comes to turning off comments for a journal entry.

When comments are enabled in any way we get this nice entry management link bar at the bottom of every entry on the single/permalink page:



But when I disable comments for an entry, I get this:



The link bar styling is gone because it seems the management links just tag along with the styling of the interaction links. I've tried styling them on their own but they ride off the link bar onto their own disheveled bar.

Can this be fixed with CSS? Or a theme layer until this is fixed in the source code?

BTW, I am using Firefox 20.0.1...

Thank you for your time.

Comments

[momijizukamori]

Knocking on themes before they are officially announced is totally acceptable (and preferred *g*). I have a good guess what's causing this, and will investigate tonight if nobody gets to it before me (pretty sure the answer is 'floats make Momijizukamori cry'), but hopefully we'll be able to get a patch in for this!

[siliconsara]

Holy crap, you're the one who coded Planet Caravan! *hugs* Thank you so much for porting this theme from spire! I am having so much fun with it, but yeah, this bug has me in stitches; and my OCD symptoms are going nuts, heh.

I await a patch! :D Thanks for the prompt reply!

[momijizukamori]

It was one of my favorites on LJ, so of course it was the first I moved *g* And you're welcome! Don't be afraid to report bugs, I always feel so silly if they float around forever before someone tells me. Can't catch everything in testing, sigh.

[momijizukamori]

Okay, I'm poking at it and I can't seem to replicate the behavior you're getting. Mostly because your screenshot has no permalink text for some reason, which should still appear even with comments disabled. Do you have a live page somewhere I could look at?

EDIT: Nevermind, I figured it out! I was looking at the wrong page *g*

[siliconsara]

Sorry about that. I went ahead and made public an entry from my private archives so you can test everything. I disabled the comments so it will show the bug in question: http://siliconsara.dreamwidth.org/37787.html

(EDIT: Glad you found it!)

[momijizukamori]

I realized after much headscratching that you meant individual entry pages, rather than the whole 'recent entries' page XD Clearly I'm not doing fantastic at reading comprehension tonight. But I've got a fix ready, so hopefully I can get Fu to push it live later

EDIT: And Mark has just pushed it live! Let me know if it's working as intended now.

[siliconsara]

LOL! No worries; it's almost 2AM here, and if it's the same where you are I can understand.

And thank you again for the speedy responses!

[momijizukamori]

It's only 11 here, and I had the day off, so I have no real excuse.

And no problem - thank you for reporting it!

[siliconsara]

I see the code push change! You fixed it, but another problem has cropped up in its place.

The entry interaction links are now "off" in line with the management links, but this might just be because of the font I'm using?

http://i35.photobucket.com/albums/d186/technodracula/newbug_zps045c0c73.jpg

Though, I fixed it with the following CSS and tested the alignment in photoshop in pixels:


ul.entry-interaction-links, .comment-interaction-links
{

margin-top: -39px;

}


I just hope my changes will be rendered properly in most modern browsers. Since I had to use px and not em (em didn't fix it).

(Testing it with browsershots, not looking good...)

(EDIT2: I think I got it to work in em! I used -2.999em instead of -39px. Didn't know em can go that far back in decimals! I checked it in photoshop and it lines up!)

[momijizukamori]

Unfortunately the way the 'opposite sides of the footer' links are done, it's nearly impossible to get them to line up perfectly - the fix that works in your browser/OS actually makes them too high in mine (though I'm looking at with a different font). I'll ask around and see if it's a problem for a lot of people and then see if we need another codepush. Otherwise I'd say stick with the override that works for your font!

[siliconsara]

Actually, spoke too soon, there seems to be a new problem. :(

http://i35.photobucket.com/albums/d186/technodracula/newnewcommentbug_zpsf0931320.jpg

The comment management links go over the interaction links. Have no idea how to go about this...

[momijizukamori]

That would be Tabula Rasa being meddlesome, which I can fix easily enough.

(blah blah conflicting alignment blah inheritence is a pain blah)

[onlyembers]

So I was browsing around here, 'cause I'm sick of staring at my own code for the moment, and I was wondering if this got fixed?

I don't know if you feel like manipulating the print_entry and print_comment functions in Planet Caravan, but putting links on the opposite side of the footer and making the freakin' things line up perfectly is relatively simple if you're willing to hurl both of the UL's into a wrapper. There's a liiiiiitttle offset when you've got images for the one side/text for the other, but it still eliminates some of the weird positioning muckery you have to do otherwise.

Then again, if not many people are having problems with the alignment, or noticing it, it might not be worth the effort…?

[momijizukamori]

Yeah, that's kind of the trade-off - I can make it ABSOLUTELY PERFECT in S2, but it's a bunch more work, and then if we make changes to any of those functions in core2, anything that overrides them has to be fixed seperately.

I think I managed to find an offset that looks near-perfect, though, so it should be a bit better than the screenshot there once the last push goes through (hopefully soonish).

(The other way, instead of adding a new wrapper, is to take print_tags out of the footer and put it up with metadata, which is what I did for Tectonic. Then you can do styling on .footer and do whatever you want with the ULs)

[onlyembers]

Yep, exactly! ;D Nudging print_tags up is what I ended up doing for the layout I'm working on. It bugged me to have to putz around with the functions for precisely the reason you just gave, but ... alas.

I just did a quick preview of Planet Caravan -- I'm not sure what they looked like before, but you've got them lining up pretty gosh darn perfect now, at least on my end.

[momijizukamori]

I just got Mark to push the fix for the left-right alignment and the vertical alignment live! So yeah, it should be better now.

And yeah, that's one of two spots that I wish we could... idk have two different versions of in core2. The other is where the userpic prints, because sometimes it's useful to have it up in the entry header wrappers.

[onlyembers]

Agreed! That's precisely the other location where I had to tinker with print_entry. It'd be really nice if the location of both could even be ... some kind of hidden property not normally displayed in the front end UI, but still something layout/theme designers could get to if they needed to. Like, sans functions putzing about. set section_userpic_position = "header"; or somesuch.

[momijizukamori]

Hmmm hmmmm. I will talk with Fu if I catch her on IRC later tonight about the feasability of that. I know a few people (including myself) who really like tags to be styled as part of metadata, visually, so I think there's reasonable desire for it - I just don't know if adding it would gum up other things back-end.

[onlyembers]

Nice! I'd love to see something like this implemented, especially since on the surface it's the same sort of concept as moving the mood/listening/location metadata around. Otoh, no idea about the back end.

[momijizukamori]

I know core2 a little bit and I can't think of any problems it would cause, but Fu is The Expert (being the person who wrote it and all), so I'll defer to her judgment. But it'd certainly give designers some more flexibility without having to write overrides

[onlyembers]

Well, it can absolutely be done, because I just bashed out a terribly messy proof of concept based on the way the metadata gets flopped around. Whether the whole notion is something that'd be feasible on a full, deployment level scale though...that's one for people who aren't epic code-manglers like me to say. XD

Looking forward to hearing what Fu tells you!

[momijizukamori]

~dramatic flourish~

[onlyembers]

*CLAPS*

Exciting, omg! Please let me know if I can be of any help with this!

[momijizukamori]

I think I have a pretty good idea of implementation, but I will let you know!

[siliconsara]

Thank you for the new code push! Everything looks great now. :D I have a one pixel offset with my management and interaction links, but I can live with that, and maybe I can replace the management links with images instead.