SOLVED: Comment user icons linking to the commenter's icons page

[london_fan]

Hi there, yet another newbie at DW here. I recently imported my highly customized Flexible Squares layout here with layout and theme layers. I changed around the bits that needed tweaking, but I got stuck on one thing. On LJ I have customized code for all icons (the 100x100 ones, not the 16x16 user icons in front of the user name) to link to the respective user's icons page. The link for entry user icons looks as follows:

<a href="$*SITEROOT/allpics.bml?user=$e.poster.username">

And this is the link for the user icons in comments:

<a href="$*SITEROOT/allpics.bml?user=$comment.poster.username">

Due to the different structure of the link to users' icons pages on DW, those links don't work here, but I'm stuck figuring out how to change them. For entries it seems to work just fine to replace the whole link with "icons", because DW will pull up the respective "username.dreamwidth.org/" part all on its own, but that doesn't work for the comment user pictures. How can I create a link to comment posters' icons pages?

Any help here would be highly appreciated.

ETA: Many thanks to chagrined for solving this and showing me how to break up link strings!

Comments

[chagrined]

Have you tried

<a href="http://$e.poster.username.dreamwidth.org/icons">
and
<a href="http://$comment.poster.username.dreamwidth.org/icons">
?

The only thing I can think is maybe having the variable in there right next to the ".dreamwidth" mayyyyy cause problems? I'd try it first and see if it works. If not maybe you could split the string up into two strings. "<a href="http://$e.poster.username" + ".dreamwidth.org/icons">" ? or w/e like that

eta: all right, I tried to use that as a string in mine it did indeed cause problems with the .dreamwidth b/c it thought that was supposed to be a substring or w/e. but then I put them on two different lines and it worked.

[london_fan]

Thank you very much for your help!

Yes, the first suggestion was one of the many things I've tried that didn't work.

Okay, I have to admit that I had no idea that you can break up link strings. I've never done it and I guess I'm doing it wrong now, because replacing <a href="$*SITEROOT/allpics.bml?user=$comment.poster.username"> with <a href="http://$e.poster.username" + ".dreamwidth.org/icons"> only produces an "The requested URL could not be retrieved" error. Apparently the browser just pulls up the first part of the string. Can you tell me what else I'd need to change to "put them on two different lines" like you said? Sorry, if that is a stupid question!

[chagrined]

are you editing the S2 layer code directly? or are you putting this in the customization wizard somewhere?

if directly, then okay, for example, in the S2 layer I am using, the part of EntryPage::print_comment() that prints the userpic is:

if ($*opt_userpic_comments and defined $e.userpic) {
    """<div class="user-icon">$e.userpic</div>""";
}

The stuff inside the """ is a string that's added to the outputted html, with ; marking the end of that expression

so you could try instead replacing it (on yours) with

"""<a href="http://$e.poster.username""" + """.dreamwidth.org/icons">""";

or,

"""<a href="http://$e.poster.username""";
""".dreamwidth.org/icons">""";

(should be effectively the same thing and if the former doesn't work you can try the latter; I recently had a weird issue with something not concatenating like I expected it to)

if you have a double quotation mark in your string then you put it inside triple-quotation marks like that.

if you are doing it through the customization wizard instead somehow then you could ~try~ putting <a href="http://$e.poster.username""" + """.dreamwidth.org/icons"> in the field, that mayyyyy work? but you may have to edit the layer S2 code directly.

[london_fan]

Thanks for the detailed explanation! That is very helpful even if I still haven't got it to work! I'm editing a S2 layer. The respective code looks like this:

# Userpic

var string userpic = "";
if ($*show_entry_userpic)
{
if ($p.view == "read" or $p.view == "entry" or $p.view == "reply")
{
if (defined $e.userpic)
{
$userpic = $userpic + """<a href="$*SITEROOT/allpics.bml?user=$e.poster.username"><img src="$e.userpic.url" width="$e.userpic.width" height="$e.userpic.height" border=0 alt="$e.poster.name" title="$e.poster.name""";
if ($e.poster.username != $e.journal.username)
{
$userpic = $userpic + " in $e.journal.name";
}
$userpic = $userpic + "\"></a>";
}
}
elseif ($p.journal_type == "C" and $p.view == "recent")
{
if (defined $e.userpic)
{
$userpic = $userpic + """<a href="$*SITEROOT/allpics.bml?user=$e.poster.username"><img src="$e.userpic.url" width="$e.userpic.width" height="$e.userpic.height" border=0 alt="$e.poster.name" title="$e.poster.name" /></a>""";
}
}
else
{
if (defined $e.userpic)
{
$userpic = $userpic + """<div class="userpic"><a href="$*SITEROOT/allpics.bml?user=$e.poster.username"><img src="$e.userpic.url" width="$e.userpic.width" height="$e.userpic.height" border=0 alt="$e.poster.name" title="$e.poster.name" /></div></a>""";
}
}


And something very similar for the comment userpics:

#Comment Userpic
if (defined $comment.userpic and $*show_entry_userpic)
{
var int w = $comment.userpic.width;
var int h = $comment.userpic.height;
var string alt = $comment.metadata{"picture_keyword"};
if ($*comment_userpic_style == "small")
{
$w = $w / 2;
$h = $h / 2;
}
if ($alt != "")
{
$alt = ": " + $alt;
}
"""
<div class="datesubjectcomment">
<a href="$*SITEROOT/allpics.bml?user=$comment.poster.username"><img class="userpiccomment" src="$comment.userpic.url" width="$w" height="$h" border=0 alt="$comment.poster.name$alt" title="$comment.poster.name$alt" /></a>""";
print """$poster on """;
print $comment->time_display("long", "");
}


I'm really sorry to keep bothering you like this, but I seem to be unable to solve this alone. Hoe can I implement the split string into this code?

[chagrined]

It's no problem! Each time it shows up you should replace it with something like, for example for the first time it shows up in that first chunk of code:

$userpic = $userpic + """<a href="$*SITEROOT/allpics.bml?user=$e.poster.username"><img src="$e.userpic.url" width="$e.userpic.width" height="$e.userpic.height" border=0 alt="$e.poster.name" title="$e.poster.name""";

becomes,

$userpic = $userpic + """<a href="http://$e.poster.username""" + """.dreamwidth.org/icons"><img src="$e.userpic.url" width="$e.userpic.width" height="$e.userpic.height" border=0 alt="$e.poster.name" title="$e.poster.name""";

and similarly for the others. Try that and see if it works?

[london_fan]

Thank you very much for your patience! I tried that, but it gives me a compiling error "Unexpected token parsing statement block", so I tried """; in-between the two parts of the string, but then the link doesn't work either.

[chagrined]

Hmmm. Would you mind uploading the full code you're using for your layers in some text files? Well, if this is in your layout layer, then you can just upload that, else if you could upload both layout & theme layer code. I'll try to make the layers myself and see if I can get it to work. :3

[london_fan]

I wouldn't mind at all! I'm really grateful that you'll go through all the trouble! Well, I'll cease further customization (read: fixing other issues like my entry linkbar links to prev and next entry not working/showing up at all) until further notice! ;)

I hope my code isn't too confusing, since it's basically a tweak of a highly customized Flexible Squares layout with the current LJ code, reverted with an older version that is compatible with DW.

Here you go!
(I'll delete the link as soon as you'll have grabbed the file if you don't mind?)

[chagrined]

yeah, I just did as described above. it's a bit different in the comment case. you can look at the code to see how it works if you are curious :)

http://www.sendspace.com/file/b9epyh

tested on my own journal and it works fine

[london_fan]

Awesome, you're a star! I'm still baffled where I did go wrong, but I suspect I had """ instead of " after .dreamwidth.org/icons.

THANK YOU VERY MUCH FOR YOUR HELP!!!

[chagrined]

yeah, lots of quotation marks, gets confusing. :)

glad to help. I'll delete the link too since you wanted to delete the other one when done.

[london_fan]

Definitely!

Thank you! I think I removed all "incriminating" code tweaks like link lists only viewable to the owner, but better safe than sorry! ;)

[london_fan]

Hi there, sorry for jumping in here again after all this time, but I thought, I'd ask you before I open a new question post, because you've helped me with this issue so marvelously in the first place. If I should rather open a new request, just tell me. In that case: SORRY for bothering you!

Anyway, the latest code push screwed up the userpics linking to the icon page again, because now there's a problem with user names that have an underscore in it... like mine.

While the code you gave me has been linking back to...

http://london_fan.dreamwidth.org/icons (with an underscore),

the new icon page is now to be found at

http://london-fan.dreamwidth.org/icons (with a hyphen).

So, do you have any idea how to "redirect" to the correct page? How can I get the underscore to be changed into a hyphen? I hope there is a simple trick, because it works with the icon in the contextual popup menu, too. So I hope that it's something simple, I just don't know.

[chagrined]

Hi, sorry for the delayed reply! Hmmm, that sounds like it's probably incorrect behavior on DW's part! Like, that should redirect or still work with the underscore. So you might want to go post in support about it and they can file a bug report! I can't think of another way to fix it off the top of my head. It's weird that the popup menu is working, though.

[london_fan]

Thanks for your reply and advice! I just opened a support request for the issue. Now I'm curious if and how it can be fixed.