Flexible squares is an S2 layout, it's just S2 Core v1, ahahaha. It gets v confusing. XD (I've imported that one as well but I'm currently using imported Expressive, another S2 Core v1 layout. Basically, the LJ-based S2 layouts are Core v1, and the DW-based S2 layouts are Core v2.)
So, the problem is indeed using expand_link() rather than print_expand_link(). If you search your layer code for "->expand_link" you should see around 2 places (maybe more depending on your style) this shows up. Replacing them with "->print_expand_link" makes it work. UNfortunately, on my style at least, this seems to mess up the spacing characters before that link item. Not quite sure why that's happening. It has me scratching my head; it's throwing the spacing characters on AFTER the link item instead of before it. So that's bizarre and I'm still trying to figure it out. But the expanding functionality is working correctly.
eta: okay, still don't really know WHY that weird problem with the spacing characters was happening, but I fixed it anyway. If you have the same problem, here is how to fix it:
when you search for "->expand_link" (which you will replace with "->print_expand_link"), you'll see it show up inside some brackets. For example, here is one of the ones that shows up for me, with a separator character in quotation marks, concatenated (the plus sign) with the return from print_expand_link():
![[community profile]](https://www.dreamwidth.org/img/silk/identity/community.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
onlyembers
no subject
Date: 2012-11-14 01:55 am (UTC)So, the problem is indeed using expand_link() rather than print_expand_link(). If you search your layer code for "->expand_link" you should see around 2 places (maybe more depending on your style) this shows up. Replacing them with "->print_expand_link" makes it work. UNfortunately, on my style at least, this seems to mess up the spacing characters before that link item. Not quite sure why that's happening. It has me scratching my head; it's throwing the spacing characters on AFTER the link item instead of before it. So that's bizarre and I'm still trying to figure it out. But the expanding functionality is working correctly.
eta: okay, still don't really know WHY that weird problem with the spacing characters was happening, but I fixed it anyway. If you have the same problem, here is how to fix it:
when you search for "->expand_link" (which you will replace with "->print_expand_link"), you'll see it show up inside some brackets. For example, here is one of the ones that shows up for me, with a separator character in quotation marks, concatenated (the plus sign) with the return from print_expand_link():
{
" " + $e->print_expand_link({ "class" => "collapsed-comment-link" });
}
All you need to do is break this up so instead of concatenating them as one expression, each is on its own line:
{
" ";
$e->print_expand_link({ "class" => "collapsed-comment-link" });
}
Problem solved! :D
P.S. This was fun to figure out and now I'm glad that expanding comments will work on my own style as well! So thanks a ton for asking it here! :D :D