(solved) Stripping HTML from subjects for sharethis buttons

[matgb]

K, I'm stuck. I'm working on a set of ShareThis buttons for my layout and a few other people. It may even get submitted as a solution to the outstanding bug on it if I can really get it working, but it'll need a lot more bells and whistles.

However, while it works fine as is for me, it breaks quite horribly if someone has put HTML into the subject of the post. According to S2 and what I've read, there are three different ways to get a plaintext subject, exept...

I can't get any of them to work. I've tried get_plain_subject (), I've tried striphtml() and I've used variants on ehtml. You can see the buttons working fine on any of my entries or friends page, but as can be seen from this one it breaks with the html.

I think I'm basically missing the syntax for how to use each of the subjects, but I've tried so many variants of syntax I think I need someone to tell me what to do.

function Entry::print_management_links() "Prints entry management links, aka prev/edit/tag/memory/tag/next, with standarized CSS." { ## There's no point in showing previous/next links on pages which show ## multiple entries anyway, so we only print them on EntryPage and ReplyPage. var Page p = get_page(); var int count; var string extras; $count = 0; """<ul class="entry-management-links">"""; var bool show_interentry = ($p.view == "entry" or $p.view == "reply"); if ($show_interentry) { $count ++; """<li class="link link_prev first-item">"""; $this->print_link_prev(); """</li>\n"""; } var Link link; foreach var string k ($.link_keyseq) { $link = $this->get_link($k); if ($link.url) { $count ++; if ($*entry_management_links == "text") { foreach var string extra ( $link.extra ) { var string value = $link.extra{$extra}; $extras = $extras + "$extra='$value' "; } """<li class="link $k""" + ( $count == 1 ? " first-item" : "" ) + """"><a href="$link.url" $extras>$link.caption</a></li>\n"""; } else { ## if ($*entry_management_links == "icon") """<li class="link $k""" + ( $count == 1 ? " first-item" : "" ) + """">$link</li>\n"""; } } } """<li class="link share share-facebook"><a href="http://www.facebook.com/sharer.php?u=$.permalink_url" title="Share on Facebook"><img src="http://www.facebook.com/favicon.ico" alt="Facebook" /></a></li>\n"""; """<li class="link share share-livejournal"><a href="http://www.livejournal.com/update.bml?subject=$.subject&event=$.subject $.permalink_url" title="Repost to Livejournal"><img src="http://www.livejournal.com/img/pencil.gif" alt="Livejournal" /></a></li>\n"""; """<li class="link share share-dreamwidth"><a href="http://www.dreamwidth.org/update.bml?subject=$.subject&event=$.subject $.permalink_url" title="Repost to Dreamwidth"><img src="http://s.dreamwidth.org/img/comm_staff.png" alt="Dreamwidth" /></a></li>\n"""; """<li class="link share share-blogger"><a href="http://www.blogger.com/blog_this.pyra?t=$.subject&u=$.permalink_url&n=$.subject" title="Repost to Blogger"><img src="http://www.blogger.com/favicon.ico" alt="Blogger" /></a></li>\n"""; """<li class="link share share-delicious"><a href="http://del.icio.us/post?url=$.permalink_url&title=$.subject" title="Share on Delicious"><img src="http://static.delicious.com/favicon.ico" alt="Delicious" /></a></li>\n"""; """<li class="link share share-twitter"><a href="http://twitter.com/home?status=$.subject&s=$.permalink_url" title="Share on Twitter"><img src="http://twitter.com/favicon.ico" alt="Tweet this" /></a></li>\n"""; """<li class="link share share-bitly"><a href="http://bit.ly/?v=3&u=$.permalink_url $.subject " title="Share with Bit.Ly"><img src="http://bit.ly/favicon.ico" alt="Bit/ly" /></a></li>\n"""; """<li class="link share share-stumbleupon"><a href="http://www.stumbleupon.com/submit?url=$.permalink_url&title=$.subject" title="Stumble This!"><img src="http://www.stumbleupon.com/favicon.ico" alt="StumbleUpon" /></a></li>\n"""; """<li class="link share share-libdig"><a href="http://libdig.co.uk/add.php?u=$.permalink_url&t=$.subject" title="LibDig This!"><img src="http://libdig.co.uk/templates/libdig/images/favicon.png" alt="LibDig" /></a></li>\n"""; if ($show_interentry) { """<li class="link link_next">"""; $this->print_link_next(); """</li>\n"""; } """</ul>"""; } <textarea></cut> So, what do I need to add? I'm pretty sure it's one simple line, I can replace $.subject with a new variable and hit myself for not seeing how easy it was and move on to making the picker tool for who wants what buttons, but... ETA: I was righ, I needed to use $this->, which is obvious as soon as you see it.

Comments

[ninetydegrees]

Creating a var:
var string subject = $this->get_plain_subject();

Then using $subject in the links seems to have worked for me. Is this what you've already tried?

[matgb]

See, I knew it would be something obvious. $this-> is what I was missing, d'oh! Thanks.

Now I can start hacking it into layouts properly, yay!

[ninetydegrees]

You're welcome. :)

[elinor]

Sorry if I'm being horridly rude asking, but did you complete your ShareThis buttons? And are they available for all users to pop into our posts?

[matgb]

I didn't TBH, I got them sorta working so they didn't break the page and then left them for another project, not done any coding at all for months, not even tweaked my layout.

I'll give it a go and let you know, they're almost finished at a basic level and I can always add more whsitles at a later date.

[elinor]

Oh wow, that would be awesome! But only if you've got the time and energy, mind :-)