Planet Caravan Style Bug?

[siliconsara]

I know it might be waaay too early to start knocking on Planet Caravan since the code roll out hasn't been publicly announced yet, but I thought I'd nip this problem quickly so other users can enjoy this beautiful theme without that *one* problem that irks them.

There's a styling bug when it comes to turning off comments for a journal entry.

When comments are enabled in any way we get this nice entry management link bar at the bottom of every entry on the single/permalink page:



But when I disable comments for an entry, I get this:



The link bar styling is gone because it seems the management links just tag along with the styling of the interaction links. I've tried styling them on their own but they ride off the link bar onto their own disheveled bar.

Can this be fixed with CSS? Or a theme layer until this is fixed in the source code?

BTW, I am using Firefox 20.0.1...

Thank you for your time.

Comments

[momijizukamori]

Yeah, that's kind of the trade-off - I can make it ABSOLUTELY PERFECT in S2, but it's a bunch more work, and then if we make changes to any of those functions in core2, anything that overrides them has to be fixed seperately.

I think I managed to find an offset that looks near-perfect, though, so it should be a bit better than the screenshot there once the last push goes through (hopefully soonish).

(The other way, instead of adding a new wrapper, is to take print_tags out of the footer and put it up with metadata, which is what I did for Tectonic. Then you can do styling on .footer and do whatever you want with the ULs)

[onlyembers]

Yep, exactly! ;D Nudging print_tags up is what I ended up doing for the layout I'm working on. It bugged me to have to putz around with the functions for precisely the reason you just gave, but ... alas.

I just did a quick preview of Planet Caravan -- I'm not sure what they looked like before, but you've got them lining up pretty gosh darn perfect now, at least on my end.

[momijizukamori]

I just got Mark to push the fix for the left-right alignment and the vertical alignment live! So yeah, it should be better now.

And yeah, that's one of two spots that I wish we could... idk have two different versions of in core2. The other is where the userpic prints, because sometimes it's useful to have it up in the entry header wrappers.

[onlyembers]

Agreed! That's precisely the other location where I had to tinker with print_entry. It'd be really nice if the location of both could even be ... some kind of hidden property not normally displayed in the front end UI, but still something layout/theme designers could get to if they needed to. Like, sans functions putzing about. set section_userpic_position = "header"; or somesuch.

[momijizukamori]

Hmmm hmmmm. I will talk with Fu if I catch her on IRC later tonight about the feasability of that. I know a few people (including myself) who really like tags to be styled as part of metadata, visually, so I think there's reasonable desire for it - I just don't know if adding it would gum up other things back-end.

[onlyembers]

Nice! I'd love to see something like this implemented, especially since on the surface it's the same sort of concept as moving the mood/listening/location metadata around. Otoh, no idea about the back end.

[momijizukamori]

I know core2 a little bit and I can't think of any problems it would cause, but Fu is The Expert (being the person who wrote it and all), so I'll defer to her judgment. But it'd certainly give designers some more flexibility without having to write overrides

[onlyembers]

Well, it can absolutely be done, because I just bashed out a terribly messy proof of concept based on the way the metadata gets flopped around. Whether the whole notion is something that'd be feasible on a full, deployment level scale though...that's one for people who aren't epic code-manglers like me to say. XD

Looking forward to hearing what Fu tells you!

[momijizukamori]

~dramatic flourish~

[onlyembers]

*CLAPS*

Exciting, omg! Please let me know if I can be of any help with this!

[momijizukamori]

I think I have a pretty good idea of implementation, but I will let you know!

[siliconsara]

Thank you for the new code push! Everything looks great now. :D I have a one pixel offset with my management and interaction links, but I can live with that, and maybe I can replace the management links with images instead.